LibWeb+LibGfx: Use GPU backend for <canvas> #1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalenikaliaksandr
force-pushed
the
gpu-canvas
branch
from
93227f6
to
ae5603a
Compare
ADKaster
reviewed
Sep 25, 2024
ADKaster
reviewed
Sep 25, 2024
kalenikaliaksandr
force-pushed
the
gpu-canvas
branch
3 times, most recently
from
6c813fc
to
f52f8b6
Compare
This is required to share GPU context creation code between display list player, which resides in LibWeb, and PainterSkia, which handles <canvas> painting.
Adds a new class in LibGfx that represents GPU-accelerated surface and will be used for both <canvas> and page rendering (display list player).
Since the Metal context is currently only used by LibGfx, it could be moved there to avoid having Metal as a dependency for everything that uses LibCore.
kalenikaliaksandr
force-pushed
the
gpu-canvas
branch
2 times, most recently
from
6e69e1a
to
1f7906f
Compare
|
I rebased the branch, but linux CI fails with following error I can't reproduce locally on my linux computer. @ADKaster any chance you know what's going on here? could this be related to CI caches? |
|
@kalenikaliaksandr Looks like you git add'd the removal of VulkanContext.cpp from one lib, but forgot to add it in the new location. LibGfx/VulkanContext.cpp needs git add'd to the PR |
kalenikaliaksandr
force-pushed
the
gpu-canvas
branch
from
1f7906f
to
7b7d8f4
Compare
oops, indeed! |
Since the Vulkan context is currently only used by LibGfx, it could be moved there to avoid having Vulkan as a dependency for everything that uses LibCore.
This is implemented by using a GPU-accelerated surface for <canvas> when a GPU context is available. A side effect of this change is that all canvas modifications have to be performed through Gfx::Painter, and whenever its content has to be accessed, we need to take a snapshot of the corresponding GPU surface. A new DrawPaintingSurface display list command is introduced to allow cheap blitting of canvas content without having to read GPU surface content into RAM.
kalenikaliaksandr
force-pushed
the
gpu-canvas
branch
from
7b7d8f4
to
e6cfa9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is implemented by using a GPU-accelerated surface for when
a GPU context is available.
A side effect of this change is that all canvas modifications have to be
performed through Gfx::Painter, and whenever its content has to be
accessed, we need to take a snapshot of the corresponding GPU surface.
A new DrawPaintingSurface display list command is introduced to allow
cheap blitting of canvas content without having to read GPU surface
content into RAM.This is a fix to the vcpkg package itself to fix some exported symbols.
This change depends on #1528 so I am marking it as a draft until it's merged.